By incompatible, you mean "rounding errors will result in your stats mysteriously changing"?Bob the Hamster wrote:We could just add documentation to setherostat letting people know that modifying maxstat is incompatible with percentage equipment buffs, and that they should setherostat with basestat instead
I guess it's tolerable, although people would already be mostly using maximumstat rather than basestat, so may not learn that their existing scripts become buggy when using percentile equipment.
And that buffing stats using out-of-battle attacks is also unsupported if you use percentile equipment? Hmm, actually it doesn't really make sense for stat-gain items to increment the max instead of the base. Suppose you have a +100% STR Armour equipped and quaff a potion that gives +6 to STR. If you quaff it while wearing the armour, you would gain +3 base STR, but if you take it off you gain +6 base. So we should definitely translate changes to max into changes to base directly without multipliers.
(The curing attack might attempt to do something weird like set your STR stat to 20. But nevermind.)
Also, we could add a convenience script command to increment/decrement a stat, since getherostat-setherostat is verbose and has these gotchas. It would modify base stat and also update the current stat.