Pokemon-style berry plant things?

Taco Bot · Post by **Taco Bot** » Thu May 19, 2016 6:29 pm

Yeah, the global counts down just fine. Then it hits 0 and the plant never comes back.

RMSephy · Post by **RMSephy** » Thu May 19, 2016 6:36 pm

Are you removing the NPCs entirely when the tag is turned on? I think nextNPCReference() will only work for NPCs that are still on the map.

Taco Bot · Post by **Taco Bot** » Thu May 19, 2016 6:38 pm

That looks like it just might be it. I've pinpointed the problem to the fact that it isn't resetting the tag. Maybe I should just make the npc invisible and change its interaction script? That seems hacky, but I guess it'd work.

Post by **Bob the Hamster** » Thu May 19, 2016 7:05 pm

Oh, that makes sense. I double-checked and yes, "next NPC reference" only loops through currently visible NPCs.

But I know another way to do this. Try this:

Code: Select all

plotscript, berryRefillUpdate, begin
   variable&#40;i, g&#41;
   for &#40;i, berryArrayStart, berryArrayEnd&#41; do &#40;
      g &#58;= readGlobal&#40;i&#41;
      if &#40;g > 0&#41; then &#40;
         writeGlobal&#40;i, g -- 1&#41;
      &#41;
   &#41;
   variable&#40;ref, arg, tag&#41;
   for &#40;ref, -300, -1&#41; do &#40;
      arg &#58;= readNpc&#40;ref, NpcStat&#58;scriptargument&#41;
      if &#40;arg >= berryArrayStart && arg <= berryArrayEnd&#41; then &#40;
         g &#58;= readGlobal&#40;arg&#41;
         if &#40;g == 0&#41; then &#40;
            tag &#58;= abs&#40;readNpc&#40;ref, 9&#41;&#41;
            setTag&#40;tag, off&#41;
         &#41;
      &#41;
   &#41;
end

The negative ref numbers from -300 to -1 are the valid range of possible NPC numbers, and I know that unlike non-existent NPC ID numbers, nonexistant NPC ref numbers are safe and will not produce any error message (I know this because I do it a lot in my own games)

Let me know if this solves the problem.

Taco Bot · Post by **Taco Bot** » Thu May 19, 2016 7:20 pm

I'm getting the same error as before...

Post by **Bob the Hamster** » Thu May 19, 2016 8:44 pm

Oops!

I said I used this method in my own scripts, but I should have looked more closely at my own scripts:

Try this:

Code: Select all

plotscript, berryRefillUpdate, begin
   variable&#40;i, g&#41;
   for &#40;i, berryArrayStart, berryArrayEnd&#41; do &#40;
      g &#58;= readGlobal&#40;i&#41;
      if &#40;g > 0&#41; then &#40;
         writeGlobal&#40;i, g -- 1&#41;
      &#41;
   &#41;
   variable&#40;ref, arg, tag&#41;
   for &#40;ref, -300, -1&#41; do&#40;
      if&#40;get NPC id&#40;ref&#41; >= 0&#41; then&#40;
         arg &#58;= readNpc&#40;ref, NpcStat&#58;scriptargument&#41;
         if &#40;arg >= berryArrayStart && arg <= berryArrayEnd&#41; then &#40;
            g &#58;= readGlobal&#40;arg&#41;
            if &#40;g == 0&#41; then &#40;
               tag &#58;= abs&#40;readNpc&#40;ref, 9&#41;&#41;
               setTag&#40;tag, off&#41;
            &#41;
         &#41;
      &#41;
   &#41;
end

The part that checks if(get NPC id(ref) >= 0) makes sure that the NPC reference is valid before it uses it.

Taco Bot · Post by **Taco Bot** » Fri May 20, 2016 2:16 am

Mr. Paige, you are my hero. It's working flawlessly now! Thank you so much for your help with this.

Post by **Bob the Hamster** » Fri May 20, 2016 2:30 am

Happy to help! :)

Post by **TMC** » Sun May 22, 2016 12:10 pm

Looks like an argument to "next npc reference" to not skip over disabled NPCs would be useful.