I wish for...

Master K · Post by **Master K** » Fri Aug 12, 2011 3:40 am

...help with this script. This script is to be used with a wishing well, just so you understand my punny title.
The script won't compile. It says that powerwish might have an extra begin or (.

Now, brace yourself. Here is the entire script. I shall break it up into two parts: The wish selection, and the wish granting script.

Code: Select all

plotscript, wishing well wealth, begin
	variable&#40;wish&#41;
	set variable&#40;wish,random,1,50&#41;
	
	if &#40;wish == 50&#41; then wealth wish
	else
	show text box&#40;37&#41;
	wait for text box
	end

plotscript, wishing well item, begin
	variable&#40;wish&#41;
	set variable&#40;wish,random,1,50&#41;
	
	if &#40;wish == 50&#41; then item wish
	else
	show text box&#40;37&#41;
	wait for text box
	end
	
plotscript, wishing well power, begin
	variable&#40;wish&#41;
	set variable&#40;wish,random,1,50&#41;
	
	if &#40;wish == 50&#41; then power wish
	else
	show text box&#40;37&#41;
	wait for text box
	end	
	
plotscript, wishing well health, begin
	variable&#40;wish&#41;
	set variable&#40;wish,random,1,50&#41;
	
	if &#40;wish == 50&#41; then health wish
	else
	show text box&#40;37&#41;
	wait for text box
	end
	
plotscript, wishing well skill, begin
	variable&#40;wish&#41;
	set variable&#40;wish,random,1,50&#41;
	
	if &#40;wish == 50&#41; then skill wish
	else
	show text box&#40;37&#41;
	wait for text box
	end

Code: Select all

plotscript, wealth wish, begin
	variable&#40;wealth&#41;
	set variable&#40;wealth,random,1,15&#41;
	
	if&#40;wealth == 1&#41; then get money&#40;5&#41;
	if&#40;wealth == 2&#41; then get money&#40;15&#41;
	if&#40;wealth == 3&#41; then get money&#40;25&#41;
	if&#40;wealth == 4&#41; then get money&#40;50&#41;
	if&#40;wealth == 5&#41; then get money&#40;100&#41;
	if&#40;wealth == 6&#41; then get money&#40;150&#41;
	if&#40;wealth == 7&#41; then get money&#40;250&#41;
	if&#40;wealth == 8&#41; then get money&#40;500&#41;
	if&#40;wealth == 9&#41; then get money&#40;750&#41;
	if&#40;wealth == 10&#41; then get money&#40;1000&#41;
	if&#40;wealth == 11&#41; then get money&#40;1200&#41;
	if&#40;wealth == 12&#41; then get money&#40;1400&#41;
	if&#40;wealth == 13&#41; then get money&#40;1600&#41;
	if&#40;wealth == 14&#41; then get money&#40;1800&#41;
	if&#40;wealth == 15&#41; then get money&#40;2000&#41;
	play sound&#40;6,false&#41;
        wait&#40;25&#41;
	show text box&#40;42&#41;
	wait for text box
	end
	
plotscript, skill wish, begin
	variable&#40;skill&#41;
	variable&#40;hero&#41;
	set variable&#40;skill,random,1,10&#41;
	hero&#58;= hero by slot&#40;0&#41;
	
	if&#40;skill == 1&#41; then teach spell&#40;hero,atk&#58;Falling&#41;
	if&#40;skill == 2&#41; then teach spell&#40;hero,atk&#58;Shooting&#41;
	if&#40;skill == 3&#41; then teach spell&#40;hero,atk&#58;Luck Shot&#41;
	if&#40;skill == 4&#41; then teach spell&#40;hero,atk&#58;Wish&#41;
	if&#40;skill == 5&#41; then teach spell&#40;hero,atk&#58;Luck Heal&#41;
	
	play sound&#40;6,false&#41;
	wait&#40;25&#41;
	
	if&#40;skill == 1&#41; then show text box&#40;46&#41;
	if&#40;skill == 2&#41; then show text box&#40;47&#41;
	if&#40;skill == 3&#41; then show text box&#40;48&#41;
	if&#40;skill == 4&#41; then show text box&#40;49&#41;
	if&#40;skill == 5&#41; then show text box&#40;50&#41;
	wait for text box
	end
	
plotscript, power wish, begin
	variable&#40;stat&#41;
	set variable&#40;stat&#40;random,1,9&#41;
	
	if&#40;stat == 1&#41; then increase HP
	if&#40;stat == 2&#41; then increase MP
	if&#40;stat == 3&#41; then increase attack
	if&#40;stat == 4&#41; then increase defense
	if&#40;stat == 5&#41; then increase aim
	if&#40;stat == 6&#41; then increase dodge
	if&#40;stat == 7&#41; then increase magic
	if&#40;stat == 8&#41; then increase will power
	if&#40;stat == 9&#41; then increase luck
	play sound&#40;6&#41;
	wait&#40;25&#41;
	show text box&#40;42&#41;
	wait for text box
	end
	
plotscript, health wish, begin
	set hero stat&#40;1,stat&#58;hp, get hero stat&#40;1,stat&#58;Health,maximum stat&#41;, current stat&#41;
        set hero stat&#40;2,stat&#58;hp, get hero stat&#40;2,stat&#58;Health,maximum stat&#41;, current stat&#41;
        set hero stat&#40;3,stat&#58;hp, get hero stat&#40;3,stat&#58;Health,maximum stat&#41;, current stat&#41;
        set hero stat&#40;4,stat&#58;hp, get hero stat&#40;4,stat&#58;Health,maximum stat&#41;, current stat&#41;
	
	set hero stat&#40;1,stat&#58;Mana, get hero stat&#40;1,stat&#58;Health,maximum stat&#41;, current stat&#41;
        set hero stat&#40;2,stat&#58;Mana, get hero stat&#40;2,stat&#58;Health,maximum stat&#41;, current stat&#41;
        set hero stat&#40;3,stat&#58;Mana, get hero stat&#40;3,stat&#58;Health,maximum stat&#41;, current stat&#41;
        set hero stat&#40;4,stat&#58;Mana, get hero stat&#40;4,stat&#58;Health,maximum stat&#41;, current stat&#41;
	play sound&#40;6,false&#41;
	wait&#40;25&#41;
	show text box&#40;44&#41;
	wait for text box
	end

I left out the item wish giving script because i'm gonna wait until later, when I have more items created. Also, feel free to clean up any other errors if you spot them.

charbile · Post by **charbile** » Fri Aug 12, 2011 12:45 pm

Random is its own function, so every instance needs to look like this:

Code: Select all

set variable&#40;wish,random&#40;1,50&#41;&#41;

Functions within functions. We must go deeper. This is a purely cosmetic preference in most ways, but instead of long if/then chains, I prefer the switch statement. Take a look, replacing "wealth wish":

Code: Select all

plotscript, wealth wish, begin 
   variable&#40;wealth&#41; 
   set variable&#40;wealth,random,1,15&#41; 

   switch &#40;wealth&#41; do
   &#40;
      case &#40;1&#41; do &#40;get money&#40;5&#41;&#41;
      case &#40;2&#41; do &#40;get money&#40;15&#41;&#41;
      case &#40;3&#41; do &#40;get money&#40;25&#41;&#41;
      #etc
   &#41;
   play sound&#40;6,false&#41; 
   while &#40;sound is playing&#40;6&#41;&#41; do&#40;wait&#40;1&#41;&#41;
   show text box&#40;42&#41; 
   wait for text box 
   end

I also changed the "wait(25)" into waiting for the sound to finish playing instead.

Post by **Bob the Hamster** » Fri Aug 12, 2011 4:35 pm

When trying to decipher hspeak's unfortunately confusing error messages, remember that ( means exactly the same thing as "begin" and ) means exactly the same thing as "end"

All of your "wishing well" have messed up "if" commands.

Also, although the "set variable" command does still work for backwards compatibility, it has been deprecated for years. You should use := to store a value in a variable (where did you even find the "set variable command"? I thought I had deleted all references to it from the documentation and examples)

Here is how it should be.

Code: Select all

plotscript, wishing well wealth, begin
   variable&#40;wish&#41;
   wish &#58;= random&#40;1, 50&#41;
   
   if &#40;wish == 50&#41; then&#40;
     wealth wish
   &#41;else&#40;
     show text box&#40;37&#41;
     wait for text box
   &#41;
end

Master K · Post by **Master K** » Fri Aug 12, 2011 10:28 pm

Thank you. But now, how can I apply it to the script? It sorta confuses me, because I don't know how it should all go. The scripts are unique and the same in the same sense.

Post by **Bob the Hamster** » Fri Aug 12, 2011 10:38 pm

I am guessing that the part you are confused about is the if/then/else stuff?

Code: Select all

   if &#40;wish == 50&#41; then&#40;
     wealth wish
   &#41;else&#40;
     show text box&#40;37&#41;
     wait for text box
   &#41;

Here is a more simplified form of the same thing

Code: Select all

   if &#40;condition&#41; then&#40;
     action
   &#41;else&#40;
     alternative
   &#41;

We could simplify that even further, and write it like this:

Code: Select all

   if &#40;condition&#41; then&#40;action&#41; else&#40;alternative&#41;

Sometimes you might see example scripts that use "then, begin" instead of "then(" but they mean exactly the same thing. The following example works the same way, but I don't recommend it, since it is kinda ugly (and involves more pointless typing, and requires confusing commas)

Code: Select all

   # Don't do it this way unless you love confusion! ;&#41;
   if &#40;condition&#41; then, begin
     action
   end, else, begin
     alternative
   end

Master K · Post by **Master K** » Mon Aug 15, 2011 7:44 pm

Still saying the powerwish might have an extra begin or (.
Heres the edited script. The stat raises and the item wish is not added.

Code: Select all

plotscript, wishing well wealth, begin
	variable&#40;wish&#41;
	set variable&#40;wish,random&#40;1,50&#41;&#41;
	
	if &#40;wish == 50&#41; then&#40; 
     wealth wish 
   &#41;else&#40; 
     show text box&#40;37&#41; 
     wait for text box 
   &#41;
     end

plotscript, wishing well item, begin
	variable&#40;wish&#41;
	set variable&#40;wish,random&#40;1,50&#41;&#41;
	
	if &#40;wish == 50&#41; then&#40; 
     item wish 
   &#41;else&#40; 
     show text box&#40;37&#41; 
     wait for text box 
   &#41; 
	end
	
plotscript, wishing well power, begin
	variable&#40;wish&#41;
	set variable&#40;wish,random&#40;1,50&#41;&#41;
	
if &#40;wish == 50&#41; then&#40; 
     power wish 
   &#41;else&#40; 
     show text box&#40;37&#41; 
     wait for text box 
   &#41; 
	end	
	
plotscript, wishing well health, begin
	variable&#40;wish&#41;
	set variable&#40;wish,random,1,25&#41;
	
	if &#40;wish == 25&#41; then&#40; 
     health wish 
   &#41;else&#40; 
     show text box&#40;37&#41; 
     wait for text box 
   &#41; 
	end
	
plotscript, wishing well skill, begin
	variable&#40;wish&#41;
	set variable&#40;wish,random,1,50&#41;
	
	if &#40;wish == 50&#41; then&#40; 
     skill wish 
   &#41;else&#40; 
     show text box&#40;37&#41; 
     wait for text box 
   &#41; 
	end
	
plotscript, wealth wish, begin
	variable&#40;wealth&#41;
	set variable&#40;wealth,random,1,15&#41;
	
	if&#40;wealth == 1&#41; then get money&#40;5&#41;
	if&#40;wealth == 2&#41; then get money&#40;15&#41;
	if&#40;wealth == 3&#41; then get money&#40;25&#41;
	if&#40;wealth == 4&#41; then get money&#40;50&#41;
	if&#40;wealth == 5&#41; then get money&#40;100&#41;
	if&#40;wealth == 6&#41; then get money&#40;150&#41;
	if&#40;wealth == 7&#41; then get money&#40;250&#41;
	if&#40;wealth == 8&#41; then get money&#40;500&#41;
	if&#40;wealth == 9&#41; then get money&#40;750&#41;
	if&#40;wealth == 10&#41; then get money&#40;1000&#41;
	if&#40;wealth == 11&#41; then get money&#40;1200&#41;
	if&#40;wealth == 12&#41; then get money&#40;1400&#41;
	if&#40;wealth == 13&#41; then get money&#40;1600&#41;
	if&#40;wealth == 14&#41; then get money&#40;1800&#41;
	if&#40;wealth == 15&#41; then get money&#40;2000&#41;
	play sound&#40;6,false&#41;
        while &#40;sound is playing&#40;6&#41;&#41; do&#40;wait&#40;1&#41;&#41; 
	show text box&#40;42&#41;
	wait for text box
	end
	
plotscript, skill wish, begin
	variable&#40;skill&#41;
	variable&#40;hero&#41;
	set variable&#40;skill,random,1,5&#41;
	hero&#58;= hero by slot&#40;0&#41;
	
	if&#40;skill == 1&#41; then teach spell&#40;hero,atk&#58;Falling&#41;
	if&#40;skill == 2&#41; then teach spell&#40;hero,atk&#58;Shooting&#41;
	if&#40;skill == 3&#41; then teach spell&#40;hero,atk&#58;Luck Shot&#41;
	if&#40;skill == 4&#41; then teach spell&#40;hero,atk&#58;Wish&#41;
	if&#40;skill == 5&#41; then teach spell&#40;hero,atk&#58;Luck Heal&#41;
	
	play sound&#40;6,false&#41;
	while &#40;sound is playing&#40;6&#41;&#41; do&#40;wait&#40;1&#41;&#41; 
	
	if&#40;skill == 1&#41; then show text box&#40;46&#41;
	if&#40;skill == 2&#41; then show text box&#40;47&#41;
	if&#40;skill == 3&#41; then show text box&#40;48&#41;
	if&#40;skill == 4&#41; then show text box&#40;49&#41;
	if&#40;skill == 5&#41; then show text box&#40;50&#41;
	wait for text box
	end
	
plotscript, power wish, begin
	variable&#40;stat&#41;
	set variable&#40;stat&#40;random,1,9&#41;
	
	if&#40;stat == 1&#41; then increase HP
	if&#40;stat == 2&#41; then increase MP
	if&#40;stat == 3&#41; then increase attack
	if&#40;stat == 4&#41; then increase defense
	if&#40;stat == 5&#41; then increase aim
	if&#40;stat == 6&#41; then increase dodge
	if&#40;stat == 7&#41; then increase magic
	if&#40;stat == 8&#41; then increase will power
	if&#40;stat == 9&#41; then increase luck
	play sound&#40;6&#41;
	while &#40;sound is playing&#40;6&#41;&#41; do&#40;wait&#40;1&#41;&#41; 
	show text box&#40;42&#41;
	wait for text box
	end
	
plotscript, health wish, begin
	set hero stat&#40;1,stat&#58;hp, get hero stat&#40;1,stat&#58;Health,maximum stat&#41;, current stat&#41;
        set hero stat&#40;2,stat&#58;hp, get hero stat&#40;2,stat&#58;Health,maximum stat&#41;, current stat&#41;
        set hero stat&#40;3,stat&#58;hp, get hero stat&#40;3,stat&#58;Health,maximum stat&#41;, current stat&#41;
        set hero stat&#40;4,stat&#58;hp, get hero stat&#40;4,stat&#58;Health,maximum stat&#41;, current stat&#41;
	
	set hero stat&#40;1,stat&#58;Mana, get hero stat&#40;1,stat&#58;Mana,maximum stat&#41;, current stat&#41;
        set hero stat&#40;2,stat&#58;Mana, get hero stat&#40;2,stat&#58;Mana,maximum stat&#41;, current stat&#41;
        set hero stat&#40;3,stat&#58;Mana, get hero stat&#40;3,stat&#58;Mana,maximum stat&#41;, current stat&#41;
        set hero stat&#40;4,stat&#58;Mana, get hero stat&#40;4,stat&#58;Mana,maximum stat&#41;, current stat&#41;
	play sound&#40;6,false&#41;
	while &#40;sound is playing&#40;6&#41;&#41; do&#40;wait&#40;1&#41;&#41; 
	show text box&#40;44&#41;
	wait for text box
	end

Post by **Bob the Hamster** » Mon Aug 15, 2011 8:45 pm

All the single-line if/then statements like this are wrong:

Code: Select all

   if&#40;wealth == 1&#41; then get money&#40;5&#41;

What the compiler sees is an "if" statement all by itself with no "then" at all. Right after that, it sees an unknown command "thengetmoney(5)"

Here is how you should write it:

Code: Select all

   if&#40;wealth == 1&#41; then&#40;get money&#40;5&#41;&#41;

Post by **TMC** » Tue Aug 16, 2011 10:35 am

Also, this is wrong:

Code: Select all

set variable&#40;stat&#40;random,1,9&#41;

It should be

Code: Select all

stat &#58;= random&#40;1,9&#41;

(If you INSIST on using setvariable, you would write "set variable (stat, random(1,9))" )