Any suggestion on how to make this script more fluid?

sheamkennedy · Post by **sheamkennedy** » Tue Mar 03, 2015 7:25 am

I have a script I'm making such that when I press "Z" on the keyboard, my hero in my party cycles to the next party member that is present if any exist. The script works fine but only carries itself out when my player is stationary. I'd like to make the code so that the player may switch character while in motion. I figure this would cause some sort of tile misalignment so thought maybe someone could instead suggest a way to make it so the code acknowledges the keypress, then changes characters once the character is aligned with the next tile.

Here's the original working code:
EDIT: I was trying to post my code but the forum isn't letting me. Maybe it's a syntax error thats throwing things out of order, sorry. If my code is absolutely necessary to solve this problem I'll find a way to post it tomorrow or something.

Gizmog · Post by **Gizmog** » Tue Mar 03, 2015 7:50 am

Try turning off HTML and BB Code, sometimes that works!

FnrrfYgmSchnish · Post by **FnrrfYgmSchnish** » Tue Mar 03, 2015 9:07 am

Or post the script inside code tags.

Code: Select all

&#91;code&#93;Insert your script here.&#91;/code&#93;

Post by **TMC** » Tue Mar 03, 2015 11:36 am

Turning off bbcode isn't necessary, but you need to turn off html if your script contains the < and > characters.

I'd never considered the case of changing the party while the heroes are moving. However, looking at the code it looks like doing that should be no problem, as the swapped hero takes the position and even the speed of the previous hero (which could be considered a bug). What happens if you try it?

sheamkennedy · Post by **sheamkennedy** » Tue Mar 03, 2015 1:29 pm

Thanks, the html being enabled was messing it up. Here's the code I currently have:

Code: Select all

    if&#40;key is pressed&#40;key&#58;Z&#41;&#41; then&#40;
      if&#40;isClimbing == 0&#41; then&#40;
        
        #suspend player
        #wait for hero &#40;me&#41;
        
        ### Cycle through players if they are in the 4 main slots
        if &#40;leader == hero&#58;Rodion&#41; then&#40;
          #Checks if character exists in 4 main slots
          if &#40;&#40;find hero&#40;hero&#58;Taras&#41; >= 0&#41; && &#40;find hero&#40;hero&#58;Taras&#41; <= 3&#41;&#41; then&#40;
            swap by name &#40;hero&#58;Taras,hero&#58;Rodion&#41;
            embiggen now
          &#41;  
        &#41;
        else if &#40;leader == hero&#58;Taras&#41; then&#40;
          #Checks if character exists in 4 main slots
          if &#40;&#40;find hero&#40;hero&#58;Rodion&#41; >= 0&#41; && &#40;find hero&#40;hero&#58;Rodion&#41; <= 3&#41;&#41; then&#40;
            swap by name &#40;hero&#58;Rodion,hero&#58;Taras&#41;
            embiggen now
          &#41;  
        &#41; 
      #resume player
      &#41; 
    &#41;

This code only seems to work if my hero is aligned with the grid even though there is nothing specifying the code to do so. Thus if I am in between tiles and press "Z" then it doesn't execute. What I would like it to do in that case is wait until I align with the next tile, then execute.

I had an idea that if I suspend the player, wait for hero (this should wait for the hero to align), then execute code and resume the player. This didn't work though...

I figured if I made an each-step script I could handle this case with a variable that is enables by the keypress, then checked for by the each-step script. This idea seems clunky though and I feel like it might be vulnerable to mishaps. I'm open to hearing other ideas before even doing this.

EDIT: After further inspection of this code by adding a long wait function in to it I was able to determine that on-keypress scripts seem to only trigger when the hero is aligned, not in mid step. I checked the plotscripting dictionary to see if this sort of behaviour is to be expected for "key is pressed" but did not find it mentioned anywhere. Due to this I believe that there could be something wrong with how "key is pressed" functions. I am curious to know if there is a way around this since I believe it would make my second coding idea not work either due to the variable not being turned on mid step...

sheamkennedy · Post by **sheamkennedy** » Tue Mar 03, 2015 3:29 pm

Disregard everything, I figured it out!

For those interested I made a stupid mistake long ago in my code which brought this on.

I had the following at the top of my onkeypress script:

Code: Select all

  if&#40;hero is walking&#40;me&#41; == false&#41; then&#40;
    set hero speed&#40;me, 4&#41;

...which had no end bracket. Followed by all my key press scripts. Thus it was checking to see if my character was standing still. Long ago I must have added an end bracket after every keypress condition in order to allow he script to compile, then didn't have a problem with keypresses until now... very silly.