Slime Salad

Posted: **Thu Feb 04, 2010 8:43 pm**

After pressing the spacebar, the script 'Activation' is supposed to see if the hero is close enough to an NPC to activate it.
If the conditions are met, then the script 'Check' is run to toss out the result of such an interaction.

Right now, the loop compares the locations of the hero and NPC's 0-17.

[edit]The script actually doesn't display properly on the forums for some reason. Leaving the posted text version here in case it's actually relevant.

Code: Select all

script, Activation, begin
variable&#40;counter&#41;

for &#40;counter, 0, 17, 1&#41;
do&#40;

if&#40;
&#40;hero pixel X &#40;me&#41; + 10&#41; >> &#40;npc pixel x &#40;counter&#41; -- 10&#41; , and,
&#40;hero pixel Y &#40;me&#41; + 10&#41; >> &#40;npc pixel y &#40;counter&#41; -- 10&#41; , and,
&#40;hero pixel X &#40;me&#41; + 10&#41; <<npc>> &#40;npc pixel y &#40;counter&#41; + 30&#41;
&#41;

then&#40;
Check &#40;counter, current map&#41;
counter &#58;= 17
&#41;

&#41;

end

Code: Select all

script, Check, npc, map, begin
if&#40;map == 1&#41;
then&#40;

if&#40;npc == 0&#41;
then&#40;
show text box &#40;16&#41;
wait for text box
&#41;

&#41;
end

However, even when the conditions are met, the script doesn't seem to acknowledge it.

NPC 0 should be activated from the pixel x-coordinates of 810-850 and pixel y-coordinates of 1350-1390.

Any insight would be appreciated, thanks.

[edit]
Tried testing 'Activation' with a true statement in place of the huge 'if' condition, and the rest of the scripts worked fine.

So the issue is most probably in there.

[edit]
Tried changing the 'if' condition to:

Code: Select all

if&#40;
&#40;npcpixelx&#40;counter&#41; -- 10&#41; << &#40;hero pixel X &#40;me&#41; + 10&#41; << &#40;npcpixelx&#40;counter&#41; + 30&#41;
&&
&#40;npcpixely&#40;counter&#41; -- 10&#41; << &#40;hero pixel Y &#40;me&#41; + 10&#41; << &#40;npcpixely&#40;counter&#41; + 30&#41;
&#41;

Now it's always true

Am thinking X<<Y<<Z doesn't mean what I think it means.

Posted: **Thu Feb 04, 2010 9:14 pm**

Right, you can't do "x << y << z" or similar. The image version you posted looks the most correct.

Your methodology is a little odd. In particular:

Code: Select all

&#40;heropixelx&#40;me&#41; + 10&#41; >> &#40;npcpixelx&#40;counter&#41; -- 10&#41;

is the same as

Code: Select all

heropixelx&#40;me&#41; >> &#40;npcpixelx&#40;counter&#41; -- 20&#41;

That shouldn't make any difference, but one is clearer (to me) than the other.

Dumb question: are you actually on map 0? Try adding "showvalue(npc)" to the beginning of your check script to see whether it's executing.

Posted: **Thu Feb 04, 2010 9:16 pm**

A first glance suggests that you have a greater than comparison where you need a less than comparison in your if statement.

Specifically, you're testing if (hero pixel Y(me) + 10) >> (npc pixel y(counter) -- 10) and if (hero pixel Y(me) + 10) >> (npc pixel y(counter) + 30)

Just replace the second '>>' with a '<<' and hopefully that'll do the trick!

Posted: **Thu Feb 04, 2010 9:23 pm**

Dumb question: are you actually on map 0?

Think you mean map 1, but tried out the 'show value' suggestion and I am indeed in the right place.

The messy math was just kind of left over from me trying to envision the center of the sprites.

Oh, while checking to see if the map was correct, I found the sweet spot for activating this guy.

Looks like the x-conditions are working at the least.

Specifically, you're testing if (hero pixel Y(me) + 10) >> (npc pixel y(counter) -- 10) and if (hero pixel Y(me) + 10) >> (npc pixel y(counter) + 30)

Just replace the second '>>' with a '<<' and hopefully that'll do the trick!

Oh! That did it.
Thanks a lot

Slime Salad

Twinconclusive's scripting issues

Twinconclusive's scripting issues

Re: Script Aid Request: Npc Activation by Pixel coordinates