Slime Salad

Posted: **Thu Mar 05, 2015 1:15 am**

I have the following code which makes my hero "run" when I hold down the "S" key. It both changes the characters speed and their sprite changes to their "running sprite." The code is here:

Code: Select all

plotscript, On Keypress Handler 0, begin
  if&#40;hero is walking&#40;me&#41; == false&#41; then&#40;
    set hero speed&#40;me, 4&#41;
    #Set leader to walking
      If &#40;hero by slot &#40;0&#41; == hero&#58;Taras&#41; then&#40;
        set hero picture &#40;0, 44&#41;
      &#41; else if &#40;hero by slot &#40;0&#41; == hero&#58;Antonina&#41; then&#40;
        set hero picture &#40;0, 47&#41;
      &#41; else if &#40;hero by slot &#40;0&#41; == hero&#58;Rodion&#41; then&#40;
        set hero picture &#40;0, 37&#41;  
      &#41;
    
  ### S ###    
      if&#40;key is pressed&#40;key&#58;S&#41;&#41; then&#40;
        set hero speed&#40;me, 5&#41;
        #Set leader to running
          If &#40;hero by slot &#40;0&#41; == hero&#58;Taras&#41; then&#40;
            set hero picture &#40;0, 99&#41;
          &#41; else if &#40;hero by slot &#40;0&#41; == hero&#58;Antonina&#41; then&#40;
            set hero picture &#40;0, 100&#41;
          &#41; else if &#40;hero by slot &#40;0&#41; == hero&#58;Rodion&#41; then&#40;
            set hero picture &#40;0, 98&#41;  
          &#41;
      &#41;
   &#41;...

This is good and all, but if I click the "S" button while stationary my hero changes to look as if they are running even though they are standing still.

To attempt to fix this I made a reset code which was called in my autorun while loop, it looked like this:

Code: Select all

script, resetRun, begin
  if&#40;hero is walking&#40;me&#41; == false&#41; then&#40;
      #Set leader to walking
      If &#40;hero by slot &#40;0&#41; == hero&#58;Taras&#41; then&#40;
        set hero picture &#40;0, 44&#41;
      &#41; else if &#40;hero by slot &#40;0&#41; == hero&#58;Antonina&#41; then&#40;
        set hero picture &#40;0, 47&#41;
      &#41; else if &#40;hero by slot &#40;0&#41; == hero&#58;Rodion&#41; then&#40;
        set hero picture &#40;0, 37&#41;  
      &#41;
  &#41;
end

It didn't work as intended... As I see it, it's checking if I'm in motion every tick and resetting my sprite if I am not. But instead what is happening is it keeps reseting my sprite even when I am in motion. I can not understand why.

Can anyone suggest an alternate way of handling this? Or point out any mistake if I made one?

Posted: **Thu Mar 05, 2015 3:56 am**

Take all of this advice with a grain of salt, because I'm not sure I totally understand the problem. What you might try to do is break it down into two parts somewhere within a while loop or someplace they're both gonna checked a lot, something like...

Code: Select all

script,SprintToggle,begin
If &#40;KeyVal &#40;Key&#58;S&#41; >> 1&#41;
then &#40;
        if &#40;CheckTag &#40;Sprinting&#41;&#41;
        then &#40;SetTag &#40;Sprinting,off&#41;
        else &#40;SetTag &#40;Sprinting,on&#41;
        &#41;
end

script,FixPictures,begin
#If the hero is walking...
if &#40;HeroIsWalking &#40;me&#41;&#41;
then &#40;
        ..check to see what pictures to do...
        if &#40;CheckTag &#40;Sprinting&#41;&#41;
        then &#40;
                #Change the pictures to the sprinting ones
               &#41;
        else &#40;
                #Change the picture to the walking ones
               &#41;
         &#41;

#If the hero ISN'T walking
else &#40;
       #Set the picture to the walking ones
       &#41;
end

I imagine there'll probably be a little bit of a delay in the pictures being right because of that "Scripts run at the end of a tick" thing TMC always talks about, but it might work... or it might not! This kind of "Hero is Moving" stuff is something that's always hard for me to wrap my brain around.

Posted: **Thu Mar 05, 2015 4:38 am**

I took from that what I could and switched over to using a tag. It kind of works. What I mean is it shows a frame of sprinting spring and flickers between that and the normal sprite while character is moving. Not sure why this happens but it gave me a good idea nonetheless. I figured it could save me time by not having to draw sprinting sprites but instead I could copy the walking sprite and just add speed-lines moving behind them. I tried it and the effect is nice so thank you. I'll consider this matter resolved.

Posted: **Thu Mar 05, 2015 4:47 am**

If it's flickering, it could be the KeyIsPressed instead of KeyVal? KeyIsPressed only cares that the button is pressed or not, not whether or not it's a new key press so 18.2 times a second KeyIsPressed is going to do what it wants to do. Glad that the matter's resolved, though!

Posted: **Thu Mar 05, 2015 6:41 am**

Gizmog wrote:If it's flickering, it could be the KeyIsPressed instead of KeyVal? KeyIsPressed only cares that the button is pressed or not, not whether or not it's a new key press so 18.2 times a second KeyIsPressed is going to do what it wants to do. Glad that the matter's resolved, though!

I actually still am using key is pressed. Didn't end up trying keyval, just ended up using a global variable to control things. I liked the look of it so didn't take things further but it's good to know for other things I may run into later. I'll show you a quick video of how it turned out.

https://www.youtube.com/watch?v=Gbcg6zB-fe8

Oh and the "R" that is blinking in the corner was what I was originally using to verify whether I was running or not, I'll be getting rid of that in the game.

Posted: **Thu Mar 05, 2015 9:44 am**

Code: Select all

script,SprintToggle,begin
If &#40;KeyVal &#40;Key&#58;S&#41; >> 1&#41;
then &#40;
        if &#40;CheckTag &#40;Sprinting&#41;&#41;
        then &#40;SetTag &#40;Sprinting,off&#41;
        else &#40;SetTag &#40;Sprinting,on&#41;
        &#41;
end

This isn't going to work, because "keyval() > 1" is true once key-repeat kicks in. So whether you use keyval or keyispressed here you'll get flicker. There's no script command to check for a true new keypress, though it's easy to write a script to check it by remembering whether the key was down last tick. I really need to add better keypress script commands, I don't know why I've put it off for years and then had to explain keyval 30 times.

I imagine there'll probably be a little bit of a delay in the pictures being right because of that "Scripts run at the end of a tick" thing TMC always talks about

No, they run at the beginning, (which is why you can momentarily turn on suspendplayer to block certain keypresses).

But you are right that if you wanted to do this properly with different sprites while moving and running you would need to work around this limitation of the script interpreter. Luckily, I already wrote a script to do that:
http://rpg.hamsterrepublic.com/ohrrpgce ... ding_still
You could have either used just the eachstep script on that page to reset the sprites to the walking one, or modify your existing resetRun script (called every tick) by changing "hero is walking(me) == false" to "hero will move == false"

Posted: **Thu Mar 05, 2015 4:09 pm**

Thanks for clarifying things.

Slime Salad

How to make hero revert to "walking" sprite once key release

How to make hero revert to "walking" sprite once k