Post new topic    
Liquid Metal King Slime
Send private message
Finished Battles collapse toggle problem (and suggestion) 
 PostFri Feb 27, 2009 6:52 pm
Send private message Reply with quote
I notice that in the arena, current matches and open challenges are both collapseable, but although "finished battles" appears to be the same kind of toggle, it does not work. Looking at the html source, I see:
Code:
onclick="javascript:toggle_visible('trFinished');"

but it seems that it does not work because the table row that contains the finished battles is actually named trLog not trFinished
Code:
tr id="trLog"


Also, I have a suggestion. Instead of grouping all the finished battles together, have a separate section for each of "Won Battles" "Lost Battles" and "Canceled Battles". Each of them could default to collapsed, to save screen-space.

It might also be nice to sort them by last change rather than by battle id number, so it would be easy to see the most recent wins/losses at the top of each respective section.
Super Slime
Send private message
 
 PostFri Feb 27, 2009 7:16 pm
Send private message Reply with quote
Whoops, fixed.

You might be pleased to know I implemented that feature for you -- or rather, I decided to implement it after seeing your arena page. You apparently haven't deleted a single finished battle from your list.

I tend to the other side of the obsessive scale -- I like to keep things tidy -- but I understand how someone with your habits could really benefit from the features you mention. I'll see what I can cook up.
Mega Tact v1.1
Super Penguin Chef
Wizard Blocks
Liquid Metal King Slime
Send private message
 
 PostFri Feb 27, 2009 7:37 pm
Send private message Reply with quote
Thanks!

Actually, I have deleted all the canceled battles... although I regret it now.

I like to look at previous battles to give me an idea how to re-balance things when I issue rematch challenges.
Super Slime
Send private message
 
 PostFri Feb 27, 2009 9:12 pm
Send private message Reply with quote
I can easily undelete them for you if you'd like.
Mega Tact v1.1
Super Penguin Chef
Wizard Blocks
Liquid Metal King Slime
Send private message
 
 PostThu Mar 05, 2009 6:00 pm
Send private message Reply with quote
Mogri wrote:
I can easily undelete them for you if you'd like.


Heh, that would be cool :)

So I was looking at the way you implemented the collapsing, and I realized that you already have everything you would need to implement a tabbed interface.

Make all the sections except one default to hidden. Move the section toggle headers up to a single row, and then change the javascript that shows a section to hide all the other sections at the same time. Boom! You have a tabbed interface!
Display posts from previous: