Issue with Hero Swap In/Out

Meatballsub · Post by **Meatballsub** » Tue Aug 13, 2013 9:29 pm

Hey guys,

Having a little issue with one hero not wanting to swap in our out of the party via scripting. Here is the code:

Code: Select all

set tag&#40;tag&#58;deathscript,on&#41;
swap out hero &#40;hero&#58;Fred&#41;
swap out hero &#40;hero&#58;Gluep&#41;
swap out hero &#40;hero&#58;Alan&#41;
add hero &#40;hero&#58;Harvey&#41;
destroy npc &#40;3&#41;
create npc &#40;6,8,2&#41;
fight formation &#40;162&#41;
swap out hero &#40;hero&#58;Harvey&#41;
swap in hero &#40;hero&#58;Fred&#41;
swap in hero &#40;hero&#58;Gluep&#41;
swap in hero &#40;hero&#58;Alan&#41;
set tag &#40;tag&#58;deathscript,off&#41;

Everything works exactly as needed, with the exception of the swap in/out with Alan. He remains in the party regardless of everything I've tried. I thought a "wait for all" before the "fight formation" might help, but it didn't. I also tried calling him by using find hero, but that doesn't work either.

I double checked the HSI file and it shows his name as hero:Alan, so I think I'm good there...any suggestions?

Post by **Bob the Hamster** » Tue Aug 13, 2013 9:37 pm

It is impossible to ever have zero heroes in the party, so if you try to swap out the last hero in the party, the swap out will just be ignored.

You can work around this problem just by changing the order of your swapping

Code: Select all

swap out hero &#40;hero&#58;Fred&#41;
swap out hero &#40;hero&#58;Gluep&#41;
add hero &#40;hero&#58;Harvey&#41;
swap out hero &#40;hero&#58;Alan&#41;

Meatballsub · Post by **Meatballsub** » Tue Aug 13, 2013 9:46 pm

Makes sense! Thanks for pointing that out, James

Post by **Mogri** » Wed Aug 14, 2013 3:03 am

Bob the Hamster wrote:It is impossible to ever have zero heroes in the party, so if you try to swap out the last hero in the party, the swap out will just be ignored.

You can work around this problem just by changing the order of your swapping
Code: Select all
swap out hero &#40;hero&#58;Fred&#41;
swap out hero &#40;hero&#58;Gluep&#41;
add hero &#40;hero&#58;Harvey&#41;
swap out hero &#40;hero&#58;Alan&#41;

FWIW, this is pretty unintuitive, and it's not hard to think of cases where the author will want to swap the entire party. It'd be nice if removing the last hero in the party put it into a "limbo" state, where the hero would be discarded if another hero gets added before the next tick and reinserted otherwise.

Post by **Bob the Hamster** » Wed Aug 14, 2013 2:18 pm

One way that I like to handle swapping is to manage specific slots, rather than just swapping out and in.

For example, suppose my part consists of 6 heroes, and I don't know which ones the player has swapped in via the Team menu.

I have a special battle that should be fought by three specific heroes with the fourth slot empty, so how do I handle the swapping before the special battle?

Code: Select all

# Force specific heroes into the first three slots
swap by position&#40;0, find hero&#40;hero&#58;Blossom&#41;&#41;
swap by position&#40;1, find hero&#40;hero&#58;Bubbles&#41;&#41;
swap by position&#40;2, find hero&#40;hero&#58;Buttercup&#41;&#41;
# Swap out whoever is in the fourth slot
if&#40;hero by slot&#40;3&#41; >= 0&#41; then&#40;swap out hero&#40;hero by slot&#40;3&#41;&#41;&#41;

But I do like your suggestion, Mogri. Allowing an empty party briefly would be more intuitive.

(also, yay "Disable html in this post"!)

Post by **TMC** » Wed Aug 14, 2013 7:14 pm

I like that suggestion too. I think it would be safe.

Recently I suggested that we should add a "set party" command which sets all party slots at once

Code: Select all

set party&#40;find hero&#40;hero&#58;Blossom&#41;, find hero&#40;hero&#58;Bubbles&#41;, find hero&#40;hero&#58;Buttercup&#41;&#41;
#or
set party by name&#40;hero&#58;Blossom, hero&#58;Bubbles, hero&#58;Buttercup&#41;